[10_6_X] Backport concurrent GEN utilities#34527
Merged
cmsbuild merged 12 commits intocms-sw:CMSSW_10_6_Xfrom Aug 31, 2021
Merged
[10_6_X] Backport concurrent GEN utilities#34527cmsbuild merged 12 commits intocms-sw:CMSSW_10_6_Xfrom
cmsbuild merged 12 commits intocms-sw:CMSSW_10_6_Xfrom
Conversation
… mergeLHE.py script (10_6_X) Backport cms-sw#33985 to 10_6_X, the config files in Configuration/Generator/ not changed
…eratorFilter (10_6_X) Backport cms-sw#34173 to 10_6_X Additional change: replace std::filesystem with boost::filesystem
Backport cms-sw#34437 to 10_6_X
…_6_X) Backport cms-sw#34525 to 10_6_X
…nizing generator types (10_6_X) Backport cms-sw#34436 to 10_6_X
Contributor
|
A new Pull Request was created by @colizz (Congqiao Li) for CMSSW_10_6_X. It involves the following packages:
@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
Contributor
|
@colizz : which workflows would you like to be tested? |
Contributor
Author
Hi @Saptaparna , maybe we can follow #33516. These include LHE(MG5, Powheg) + Hadronzier(P8, H7) routines. But we do not specify the use of concurrent utilities in any workflow yet. Is it required to modify the configs in a similar way under 10_6_X? |
Contributor
Contributor
Author
|
Thanks, so as we discussed in GEN meeting and offline, I'll first make a change in RelVal workflows in the master branch. Then I'll backport the change by a follow-up commit in this PR. |
Contributor
@colizz kindly ping. |
Contributor
Author
|
(will come back and finalize this thread by Friday - apologies for the delay) |
Contributor
|
test parameters:
|
Backport cms-sw#29554 to 10_6_X
Backport cms-sw#33599 to 10_6_X
…hon` to enable concurrent GEN Big backport from cms-sw#34710 following the same four-step rule. It also includes the backport of cms-sw#29305, cms-sw#33516, cms-sw#34463 with the same goal (these are never backported to 10_6_X)
Contributor
|
Pull request #34527 was updated. @SiewYan, @mkirsano, @jordan-martins, @chayanit, @bbilin, @wajidalikhan, @Saptaparna, @cmsbuild, @AdrianoDee, @srimanob, @agrohsje, @kpedro88, @kskovpen, @alberto-sanchez, @santocch, @GurpreetSinghChahal can you please check and sign again. |
Contributor
Author
|
Backport the changes on cfi/cff files in
We validated on all modified RelVal workflows for 10_6_X: [click to expend]
Appendix: [click to expend]
Note that the new IDs we add are :
|
Contributor
|
test parameters:
|
Contributor
|
Pull request #34527 was updated. @SiewYan, @mkirsano, @jordan-martins, @chayanit, @bbilin, @wajidalikhan, @Saptaparna, @cmsbuild, @AdrianoDee, @srimanob, @agrohsje, @kpedro88, @kskovpen, @alberto-sanchez, @santocch, @GurpreetSinghChahal can you please check and sign again. |
Contributor
Author
|
The change is done (backport of #35072), please help to test again, thanks! (PR description also modified) |
Contributor
|
please test |
Contributor
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-850492/18140/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
Contributor
|
Looks good now. thanks @colizz @cms-sw/pdmv-l2 @cms-sw/generators-l2 @cms-sw/upgrade-l2 Would you please check and sign again? |
|
+generators |
Contributor
|
+upgrade |
Contributor
|
+1 |
Contributor
|
+1 |
Contributor
|
merge |
|
+1 |
cmsbuild
added
analysis-approved
fully-signed
and removed
analysis-pending
pending-signatures
labels
Contributor
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will be automatically merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
Backports of all recently developed/modified concurrent GEN utilities to 10_6_X, to benefit UL event processing.
The PR includes the following changes
Configuration/Generator/pythonto enable concurrent GEN. This includes several items (see details in [10_6_X] Backport concurrent GEN utilities #34527 (comment)):Small modifications are made, if necessary, to adapt the 10_6_X code. Please see details in each commit message.
PR validation:
Validations are made on specific UL processes to see the GEN utility works (some recipes below).
We also validate the physics result on the vast UL samples under 10_6_X, which are reported to GEN group. Please see slides here.
validated on
JME-RunIISummer20UL17wmLHEGEN-00001(MG5+Herwig7)2&3:
validated on Pythia8+Tauola workflow
cmsDriver.py GGToHtautau_13TeV_pythia8_Tauola_taupinu_cff --conditions auto:run2_mc -s GEN --datatier GEN --beamspot Realistic8TeVCollision -n 20 --relval 250000,5000 --eventcontent RAWSIM --fileout file:step1.root --nThreads 4 \ --customise_commands="from GeneratorInterface.Core.ExternalGeneratorFilter import ExternalGeneratorFilter; process.generator = ExternalGeneratorFilter(process.generator, _external_process_components_=cms.vstring('HepPDTESSource'))"4:
validated on
B2G-RunIISummer19UL17wmLHEGEN-00001(MG5+Pythia8)See validation in the original PR.
validated on Pythia8+Tauola and process till the NanoGEN step
See that the
GenJet_partonFlavourbranch is recovered.8/9. See validation in the original PR.